Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/24536 )
Change subject: POC IMPALA-15162: Add GEOMETRY column support for Iceberg and Parquet ...................................................................... Patch Set 5: (4 comments) gerrit-auto-critic failed. You can reproduce it locally using command: python3 bin/jenkins/critique-gerrit-review.py --dryrun To run it, you might need a virtual env with Python3's venv installed. http://gerrit.cloudera.org:8080/#/c/24536/5/java/shaded-deps/impala-iceberg-runtime/src/main/java/org/apache/iceberg/hive/HiveSchemaUtil.java File java/shaded-deps/impala-iceberg-runtime/src/main/java/org/apache/iceberg/hive/HiveSchemaUtil.java: http://gerrit.cloudera.org:8080/#/c/24536/5/java/shaded-deps/impala-iceberg-runtime/src/main/java/org/apache/iceberg/hive/HiveSchemaUtil.java@34 PS5, Line 34: * These types are mapped to "binary" in Hive since HMS has no native geometry/geography type. line too long (94 > 90) http://gerrit.cloudera.org:8080/#/c/24536/5/java/shaded-deps/impala-iceberg-runtime/src/main/java/org/apache/iceberg/hive/HiveSchemaUtil.java@46 PS5, Line 46: .map(col -> new FieldSchema(col.name(), convertToTypeString(col.type()), col.doc())) line too long (92 > 90) http://gerrit.cloudera.org:8080/#/c/24536/5/java/shaded-deps/impala-iceberg-runtime/src/main/java/org/apache/iceberg/hive/HiveSchemaUtil.java@120 PS5, Line 120: return String.format("decimal(%s,%s)", decimalType.precision(), decimalType.scale()); line too long (93 > 90) http://gerrit.cloudera.org:8080/#/c/24536/5/tests/custom_cluster/test_geospatial_library.py File tests/custom_cluster/test_geospatial_library.py: http://gerrit.cloudera.org:8080/#/c/24536/5/tests/custom_cluster/test_geospatial_library.py@105 PS5, Line 105: v flake8: U100 Unused argument 'vector' -- To view, visit http://gerrit.cloudera.org:8080/24536 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I32d8c12a6b71708646fbfc06a6dd8f7aaf4f5e6b Gerrit-Change-Number: 24536 Gerrit-PatchSet: 5 Gerrit-Owner: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Balazs Hevele <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Comment-Date: Fri, 10 Jul 2026 11:33:44 +0000 Gerrit-HasComments: Yes
