Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/24536 )
Change subject: POC: Add GEOMETRY column support for Iceberg and Parquet ...................................................................... Patch Set 4: (8 comments) gerrit-auto-critic failed. You can reproduce it locally using command: python3 bin/jenkins/critique-gerrit-review.py --dryrun To run it, you might need a virtual env with Python3's venv installed. http://gerrit.cloudera.org:8080/#/c/24536/4/common/thrift/parquet.thrift File common/thrift/parquet.thrift: http://gerrit.cloudera.org:8080/#/c/24536/4/common/thrift/parquet.thrift@351 PS4, Line 351: struct Float16Type {} // allowed for FIXED[2], must be encoded as raw FLOAT16 bytes (see LogicalTypes.md) line too long (105 > 90) http://gerrit.cloudera.org:8080/#/c/24536/4/common/thrift/parquet.thrift@506 PS4, Line 506: 5: DecimalType DECIMAL // use ConvertedType DECIMAL + SchemaElement.{scale, precision} line too long (93 > 90) http://gerrit.cloudera.org:8080/#/c/24536/4/common/thrift/parquet.thrift@782 PS4, Line 782: definition_levels_byte_length + repetition_levels_byte_length and compressed_page_size (included) line too long (99 > 90) http://gerrit.cloudera.org:8080/#/c/24536/4/common/thrift/parquet.thrift@1012 PS4, Line 1012: * reference implementations that will read externally stored column data if this field is populated line too long (103 > 90) http://gerrit.cloudera.org:8080/#/c/24536/4/java/shaded-deps/impala-iceberg-runtime/src/main/java/org/apache/iceberg/hive/HiveSchemaUtil.java File java/shaded-deps/impala-iceberg-runtime/src/main/java/org/apache/iceberg/hive/HiveSchemaUtil.java: http://gerrit.cloudera.org:8080/#/c/24536/4/java/shaded-deps/impala-iceberg-runtime/src/main/java/org/apache/iceberg/hive/HiveSchemaUtil.java@34 PS4, Line 34: * These types are mapped to "binary" in Hive since HMS has no native geometry/geography type. line too long (94 > 90) http://gerrit.cloudera.org:8080/#/c/24536/4/java/shaded-deps/impala-iceberg-runtime/src/main/java/org/apache/iceberg/hive/HiveSchemaUtil.java@46 PS4, Line 46: .map(col -> new FieldSchema(col.name(), convertToTypeString(col.type()), col.doc())) line too long (92 > 90) http://gerrit.cloudera.org:8080/#/c/24536/4/java/shaded-deps/impala-iceberg-runtime/src/main/java/org/apache/iceberg/hive/HiveSchemaUtil.java@120 PS4, Line 120: return String.format("decimal(%s,%s)", decimalType.precision(), decimalType.scale()); line too long (93 > 90) http://gerrit.cloudera.org:8080/#/c/24536/4/tests/custom_cluster/test_geospatial_library.py File tests/custom_cluster/test_geospatial_library.py: http://gerrit.cloudera.org:8080/#/c/24536/4/tests/custom_cluster/test_geospatial_library.py@108 PS4, Line 108: v flake8: U100 Unused argument 'vector' -- To view, visit http://gerrit.cloudera.org:8080/24536 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I32d8c12a6b71708646fbfc06a6dd8f7aaf4f5e6b Gerrit-Change-Number: 24536 Gerrit-PatchSet: 4 Gerrit-Owner: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Balazs Hevele <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Comment-Date: Thu, 09 Jul 2026 14:39:21 +0000 Gerrit-HasComments: Yes
