Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/10850 )
Change subject: IMPALA-6086: Use of permanent function should require SELECT privilege on DB ...................................................................... Patch Set 2: (6 comments) http://gerrit.cloudera.org:8080/#/c/10850/2/fe/src/test/java/org/apache/impala/analysis/AuthorizationStmtTest.java File fe/src/test/java/org/apache/impala/analysis/AuthorizationStmtTest.java: http://gerrit.cloudera.org:8080/#/c/10850/2/fe/src/test/java/org/apache/impala/analysis/AuthorizationStmtTest.java@2084 PS2, Line 2084: nit: add two extra spaces for continued indentation http://gerrit.cloudera.org:8080/#/c/10850/2/fe/src/test/java/org/apache/impala/analysis/AuthorizationStmtTest.java@2087 PS2, Line 2087: "select functional.to_lower('ABCDEF')") nit: move L2088 to L2087 http://gerrit.cloudera.org:8080/#/c/10850/2/fe/src/test/java/org/apache/impala/analysis/AuthorizationStmtTest.java@2091 PS2, Line 2091: .ok(onDatabase("functional", TPrivilegeLevel.ALL)) nit: move .ok(onDatabase("functional", TPrivilegeLevel.ALL)) to be at the beginning (L2089) to be consistent with other code http://gerrit.cloudera.org:8080/#/c/10850/2/fe/src/test/java/org/apache/impala/analysis/AuthorizationStmtTest.java@2092 PS2, Line 2092: .ok(onDatabase("functional", TPrivilegeLevel.INSERT)) : .ok(onDatabase("functional", TPrivilegeLevel.REFRESH)) INSERT, REFRESH, and SELECT can be simplified to .ok(onDatabase("functional", viewMetadataPrivileges()) http://gerrit.cloudera.org:8080/#/c/10850/2/fe/src/test/java/org/apache/impala/analysis/AuthorizationStmtTest.java@2096 PS2, Line 2096: TPrivilegeLevel.SELECT, TPrivilegeLevel.ALL, : TPrivilegeLevel.INSERT, TPrivilegeLevel.REFRESH can be simplified to allExcept(viewMetadataPrivileges()) http://gerrit.cloudera.org:8080/#/c/10850/2/fe/src/test/java/org/apache/impala/analysis/AuthorizationStmtTest.java@2167 PS2, Line 2167: uriPath, symbolName, null, null, nit: move L2168 to L2167 -- To view, visit http://gerrit.cloudera.org:8080/10850 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iee70f15e4c04f7daaed9cac2400ec626e1fb0e57 Gerrit-Change-Number: 10850 Gerrit-PatchSet: 2 Gerrit-Owner: Zoram Thanga <[email protected]> Gerrit-Reviewer: Fredy Wijaya <[email protected]> Gerrit-Reviewer: Vuk Ercegovac <[email protected]> Gerrit-Reviewer: Zoram Thanga <[email protected]> Gerrit-Comment-Date: Tue, 03 Jul 2018 20:15:21 +0000 Gerrit-HasComments: Yes
