Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/10850 )
Change subject: IMPALA-6086: Use of permanent function should require SELECT privilege on DB ...................................................................... Patch Set 3: (5 comments) looks fine, just some minor additional comments. http://gerrit.cloudera.org:8080/#/c/10850/3/fe/src/main/java/org/apache/impala/analysis/AnalysisContext.java File fe/src/main/java/org/apache/impala/analysis/AnalysisContext.java: http://gerrit.cloudera.org:8080/#/c/10850/3/fe/src/main/java/org/apache/impala/analysis/AnalysisContext.java@481 PS3, Line 481: LOG.trace("rewrittenStmt: " + analysisResult_.stmt_.toSql()); > I think that's the right approach in general: Parse the statement, then che ok. looks like this change is an improvement over the current behavior. pls file a jira to make such checks earlier. http://gerrit.cloudera.org:8080/#/c/10850/3/fe/src/test/java/org/apache/impala/analysis/AuthorizationStmtTest.java File fe/src/test/java/org/apache/impala/analysis/AuthorizationStmtTest.java: http://gerrit.cloudera.org:8080/#/c/10850/3/fe/src/test/java/org/apache/impala/analysis/AuthorizationStmtTest.java@2070 PS3, Line 2070: // nit: remove http://gerrit.cloudera.org:8080/#/c/10850/3/fe/src/test/java/org/apache/impala/analysis/AuthorizationStmtTest.java@2074 PS3, Line 2074: // nit: remove http://gerrit.cloudera.org:8080/#/c/10850/3/fe/src/test/java/org/apache/impala/analysis/AuthorizationStmtTest.java@2085 PS3, Line 2085: // Enable expression rewrite move above L2082? http://gerrit.cloudera.org:8080/#/c/10850/3/fe/src/test/java/org/apache/impala/analysis/AuthorizationStmtTest.java@2153 PS3, Line 2153: ScalarFunction fn = ScalarFunction.createForTesting(db, fnName, : new ArrayList<Type>(), Type.INT, "/dummy", "dummy.class", null, : null, TFunctionBinaryType.NATIVE); : authzCatalog_.addFunction(fn); replace with a call to the more generic function on L2160 -- To view, visit http://gerrit.cloudera.org:8080/10850 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iee70f15e4c04f7daaed9cac2400ec626e1fb0e57 Gerrit-Change-Number: 10850 Gerrit-PatchSet: 3 Gerrit-Owner: Zoram Thanga <[email protected]> Gerrit-Reviewer: Fredy Wijaya <[email protected]> Gerrit-Reviewer: Vuk Ercegovac <[email protected]> Gerrit-Reviewer: Zoram Thanga <[email protected]> Gerrit-Comment-Date: Wed, 11 Jul 2018 23:08:36 +0000 Gerrit-HasComments: Yes
