Zoram Thanga has posted comments on this change. ( http://gerrit.cloudera.org:8080/10850 )
Change subject: IMPALA-6086: Use of permanent function should require SELECT privilege on DB ...................................................................... Patch Set 4: (8 comments) http://gerrit.cloudera.org:8080/#/c/10850/3//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/10850/3//COMMIT_MSG@10 PS3, Line 10: leas > nit: least Done http://gerrit.cloudera.org:8080/#/c/10850/3//COMMIT_MSG@18 PS3, Line 18: > add a "Testing: " section header. Done http://gerrit.cloudera.org:8080/#/c/10850/3//COMMIT_MSG@24 PS3, Line 24: : Ran exhaustive and > nit: replace with "Ran exhaustive and covering tests." Done http://gerrit.cloudera.org:8080/#/c/10850/3/fe/src/main/java/org/apache/impala/analysis/AnalysisContext.java File fe/src/main/java/org/apache/impala/analysis/AnalysisContext.java: http://gerrit.cloudera.org:8080/#/c/10850/3/fe/src/main/java/org/apache/impala/analysis/AnalysisContext.java@481 PS3, Line 481: LOG.trace("rewrittenStmt: " + analysisResult_.stmt_.toSql()); > ok. looks like this change is an improvement over the current behavior. pls Filed https://issues.apache.org/jira/browse/IMPALA-7285 http://gerrit.cloudera.org:8080/#/c/10850/3/fe/src/test/java/org/apache/impala/analysis/AuthorizationStmtTest.java File fe/src/test/java/org/apache/impala/analysis/AuthorizationStmtTest.java: http://gerrit.cloudera.org:8080/#/c/10850/3/fe/src/test/java/org/apache/impala/analysis/AuthorizationStmtTest.java@2070 PS3, Line 2070: > nit: remove Done http://gerrit.cloudera.org:8080/#/c/10850/3/fe/src/test/java/org/apache/impala/analysis/AuthorizationStmtTest.java@2074 PS3, Line 2074: fo > nit: remove Done http://gerrit.cloudera.org:8080/#/c/10850/3/fe/src/test/java/org/apache/impala/analysis/AuthorizationStmtTest.java@2085 PS3, Line 2085: .ok(onServer(TPrivilegeLevel > move above L2082? Changed the text so that the context is clearer. http://gerrit.cloudera.org:8080/#/c/10850/3/fe/src/test/java/org/apache/impala/analysis/AuthorizationStmtTest.java@2153 PS3, Line 2153: ivate static String alterError(String object) { : return "User '%s' does not have privileges to execute 'ALTER' on: " + object; : } : > replace with a call to the more generic function on L2160 Done -- To view, visit http://gerrit.cloudera.org:8080/10850 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iee70f15e4c04f7daaed9cac2400ec626e1fb0e57 Gerrit-Change-Number: 10850 Gerrit-PatchSet: 4 Gerrit-Owner: Zoram Thanga <zo...@cloudera.com> Gerrit-Reviewer: Fredy Wijaya <fwij...@cloudera.com> Gerrit-Reviewer: Vuk Ercegovac <vercego...@cloudera.com> Gerrit-Reviewer: Zoram Thanga <zo...@cloudera.com> Gerrit-Comment-Date: Thu, 12 Jul 2018 23:37:04 +0000 Gerrit-HasComments: Yes
