Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/24543 )
Change subject: IMPALA-15054: Set EXPAND_COMPLEX_TYPES to true by default ...................................................................... Patch Set 3: (3 comments) http://gerrit.cloudera.org:8080/#/c/24543/3//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/24543/3//COMMIT_MSG@41 PS3, Line 41: resolution nit: listing looks unnecessarily detailed http://gerrit.cloudera.org:8080/#/c/24543/3/testdata/workloads/functional-query/queries/QueryTest/iceberg-metadata-tables.test File testdata/workloads/functional-query/queries/QueryTest/iceberg-metadata-tables.test: http://gerrit.cloudera.org:8080/#/c/24543/3/testdata/workloads/functional-query/queries/QueryTest/iceberg-metadata-tables.test@1178 PS3, Line 1178: 0 why 0? other places use false http://gerrit.cloudera.org:8080/#/c/24543/3/testdata/workloads/functional-query/queries/QueryTest/iceberg-migrated-table-field-id-resolution-complex.test File testdata/workloads/functional-query/queries/QueryTest/iceberg-migrated-table-field-id-resolution-complex.test: http://gerrit.cloudera.org:8080/#/c/24543/3/testdata/workloads/functional-query/queries/QueryTest/iceberg-migrated-table-field-id-resolution-complex.test@47 PS3, Line 47: set expand_complex_types=true; I saw couple of places where it is set to true - can we remove these from the tests? This would also make it clear from the patch which test has an expanded pair, and which doesn't. It may be better to duplicate some tests and check both ways. -- To view, visit http://gerrit.cloudera.org:8080/24543 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6cf01f0b6bb3b5fa2aa770c77bc772abf9cc84b2 Gerrit-Change-Number: 24543 Gerrit-PatchSet: 3 Gerrit-Owner: Zoltan Borok-Nagy <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Comment-Date: Tue, 07 Jul 2026 06:15:53 +0000 Gerrit-HasComments: Yes
