Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/24543 )
Change subject: IMPALA-15054: Set EXPAND_COMPLEX_TYPES to true by default ...................................................................... Patch Set 4: (4 comments) http://gerrit.cloudera.org:8080/#/c/24543/4/fe/src/test/java/org/apache/impala/analysis/AnalyzeStmtsTest.java File fe/src/test/java/org/apache/impala/analysis/AnalyzeStmtsTest.java: http://gerrit.cloudera.org:8080/#/c/24543/4/fe/src/test/java/org/apache/impala/analysis/AnalyzeStmtsTest.java@1113 PS4, Line 1113: // EXPAND_COMPLEX_TYPES defaults to true, so use a context that sets it to false. Maybe it would be clearer to move these to a new test like TestDisableExpandComplexTypes? http://gerrit.cloudera.org:8080/#/c/24543/4/fe/src/test/java/org/apache/impala/analysis/AnalyzeStmtsTest.java@1187 PS4, Line 1187: ctx.getQueryOptions().setExpand_complex_types(true); could be removed - at this point it is misleading http://gerrit.cloudera.org:8080/#/c/24543/4/fe/src/test/java/org/apache/impala/analysis/AnalyzerTest.java File fe/src/test/java/org/apache/impala/analysis/AnalyzerTest.java: http://gerrit.cloudera.org:8080/#/c/24543/4/fe/src/test/java/org/apache/impala/analysis/AnalyzerTest.java@349 PS4, Line 349: 'c.int_array' collection alias couldn't simply give an alias to c.int_array? It doesn't change the intention of this test. http://gerrit.cloudera.org:8080/#/c/24543/4/testdata/workloads/functional-planner/queries/PlannerTest/empty.test File testdata/workloads/functional-planner/queries/PlannerTest/empty.test: http://gerrit.cloudera.org:8080/#/c/24543/4/testdata/workloads/functional-planner/queries/PlannerTest/empty.test@609 PS4, Line 609: # EXPAND_COMPLEX_TYPES defaults to true; set it to false here because 'select *' would : # otherwise expand the c_orders array column, which collides with the c.c_orders : # collection alias ("Duplicate table alias"). Wouldn't an alias help? -- To view, visit http://gerrit.cloudera.org:8080/24543 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6cf01f0b6bb3b5fa2aa770c77bc772abf9cc84b2 Gerrit-Change-Number: 24543 Gerrit-PatchSet: 4 Gerrit-Owner: Zoltan Borok-Nagy <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Wed, 08 Jul 2026 06:36:54 +0000 Gerrit-HasComments: Yes
