Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/24543 )
Change subject: IMPALA-15054: Set EXPAND_COMPLEX_TYPES to true by default ...................................................................... Patch Set 4: (6 comments) Thanks for the comments! http://gerrit.cloudera.org:8080/#/c/24543/3//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/24543/3//COMMIT_MSG@41 PS3, Line 41: ing the re > nit: listing looks unnecessarily detailed Done http://gerrit.cloudera.org:8080/#/c/24543/2/fe/src/main/java/org/apache/impala/analysis/SelectStmt.java File fe/src/main/java/org/apache/impala/analysis/SelectStmt.java: http://gerrit.cloudera.org:8080/#/c/24543/2/fe/src/main/java/org/apache/impala/analysis/SelectStmt.java@893 PS2, Line 893: * EXPAND_COMPLEX_TYPES is set to false (it defaults to true); > line too long (93 > 90) Done http://gerrit.cloudera.org:8080/#/c/24543/2/fe/src/test/java/org/apache/impala/analysis/AnalyzeStmtsTest.java File fe/src/test/java/org/apache/impala/analysis/AnalyzeStmtsTest.java: http://gerrit.cloudera.org:8080/#/c/24543/2/fe/src/test/java/org/apache/impala/analysis/AnalyzeStmtsTest.java@1119 PS2, Line 1119: AnalyzesOk("select complex_struct_col.* from functional.allcomplextypes", > line too long (91 > 90) Done http://gerrit.cloudera.org:8080/#/c/24543/2/fe/src/test/java/org/apache/impala/analysis/AnalyzeStmtsTest.java@4794 PS2, Line 4794: "support inserting into tables containing complex type columns"); > line too long (91 > 90) Done http://gerrit.cloudera.org:8080/#/c/24543/3/testdata/workloads/functional-query/queries/QueryTest/iceberg-metadata-tables.test File testdata/workloads/functional-query/queries/QueryTest/iceberg-metadata-tables.test: http://gerrit.cloudera.org:8080/#/c/24543/3/testdata/workloads/functional-query/queries/QueryTest/iceberg-metadata-tables.test@1178 PS3, Line 1178: f > why 0? other places use false Done http://gerrit.cloudera.org:8080/#/c/24543/3/testdata/workloads/functional-query/queries/QueryTest/iceberg-migrated-table-field-id-resolution-complex.test File testdata/workloads/functional-query/queries/QueryTest/iceberg-migrated-table-field-id-resolution-complex.test: http://gerrit.cloudera.org:8080/#/c/24543/3/testdata/workloads/functional-query/queries/QueryTest/iceberg-migrated-table-field-id-resolution-complex.test@47 PS3, Line 47: set expand_complex_types=true; > I saw couple of places where it is set to true - can we remove these from t This .test file is full of duplicated tests, I think it's good that the query option expand_complex_types is now explicit for each query. It makes the intent of the queries more clear. -- To view, visit http://gerrit.cloudera.org:8080/24543 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6cf01f0b6bb3b5fa2aa770c77bc772abf9cc84b2 Gerrit-Change-Number: 24543 Gerrit-PatchSet: 4 Gerrit-Owner: Zoltan Borok-Nagy <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Tue, 07 Jul 2026 08:42:10 +0000 Gerrit-HasComments: Yes
