Aleksandr Efimov has posted comments on this change. ( http://gerrit.cloudera.org:8080/24353 )
Change subject: IMPALA-12956: Add profile summary output ...................................................................... Patch Set 7: (1 comment) http://gerrit.cloudera.org:8080/#/c/24353/7/be/src/util/impala-profile-tool.cc File be/src/util/impala-profile-tool.cc: http://gerrit.cloudera.org:8080/#/c/24353/7/be/src/util/impala-profile-tool.cc@354 PS7, Line 354: ParseUtil::ParseMemSpec > Any reason that we rollback to not using ParseUtil::ParseMemSpec()? Fixed in PS10. Restored `ParseUtil::ParseMemSpec()` reuse for memory parsing and split `ParseMemSpec()` into a small utility source so `impala-profile-tool` links it without pulling in compression-codec dependencies. Thanks for catching this. -- To view, visit http://gerrit.cloudera.org:8080/24353 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I35da958106ffb35b14ef867da50ed23ffda0a45b Gerrit-Change-Number: 24353 Gerrit-PatchSet: 7 Gerrit-Owner: Aleksandr Efimov <[email protected]> Gerrit-Reviewer: Aleksandr Efimov <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jason Fehr <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Comment-Date: Tue, 07 Jul 2026 17:02:12 +0000 Gerrit-HasComments: Yes
