Aleksandr Efimov has posted comments on this change. ( http://gerrit.cloudera.org:8080/24353 )
Change subject: IMPALA-12956: Add profile summary output ...................................................................... Patch Set 9: (4 comments) http://gerrit.cloudera.org:8080/#/c/24353/9/be/src/util/progress-util.cc File be/src/util/progress-util.cc: http://gerrit.cloudera.org:8080/#/c/24353/9/be/src/util/progress-util.cc@31 PS9, Line 31: ss << "0%)"; > setw only affects the next item. On L33 it's the percent value without "%)" Fixed in PS10. The zero-progress branch now writes the padded numeric value and suffix separately with `ss << "0" << "%)"`; the expected strings were updated accordingly. Thanks. http://gerrit.cloudera.org:8080/#/c/24353/9/be/src/util/summary-util.h File be/src/util/summary-util.h: http://gerrit.cloudera.org:8080/#/c/24353/9/be/src/util/summary-util.h@21 PS9, Line 21: #include <string> > nit: why do we need this now? Fixed in PS10. Removed the unnecessary `<string>` include. http://gerrit.cloudera.org:8080/#/c/24353/9/be/src/util/summary-util.cc File be/src/util/summary-util.cc: http://gerrit.cloudera.org:8080/#/c/24353/9/be/src/util/summary-util.cc@20 PS9, Line 20: #include <sstream> > nit: why do we need this now? Fixed in PS10. Removed the unnecessary `<sstream>` include. http://gerrit.cloudera.org:8080/#/c/24353/9/be/src/util/summary-util.cc@22 PS9, Line 22: > nit: please don't add blank lines like this Fixed in PS10. Removed the added blank line. -- To view, visit http://gerrit.cloudera.org:8080/24353 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I35da958106ffb35b14ef867da50ed23ffda0a45b Gerrit-Change-Number: 24353 Gerrit-PatchSet: 9 Gerrit-Owner: Aleksandr Efimov <[email protected]> Gerrit-Reviewer: Aleksandr Efimov <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jason Fehr <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Comment-Date: Tue, 07 Jul 2026 17:03:06 +0000 Gerrit-HasComments: Yes
