Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/24378 )
Change subject: IMPALA-14099: Tolerate large profile log timestamps ...................................................................... IMPALA-14099: Tolerate large profile log timestamps impala-profile-tool parsed profile log timestamps directly as int64_t before reading the rest of the line. Very large timestamp values made stream extraction fail, so the tool rejected the whole profile even when timestamp filters were not used. Read the timestamp field as text and only convert it to int64_t when --min_timestamp or --max_timestamp filtering needs numeric comparison. This preserves filtering for normal timestamps while allowing profile payload decoding when the timestamp is not needed. Add regression tests for timestamp filtering. Also cover decoding an existing public fixture after replacing its timestamp with the oversized value from IMPALA-14099. Testing: - compiled impala-profile-tool in Lima VM using the exact patched source and existing debug libraries - manual oversized-timestamp smoke test - bin/impala-py.test -q tests/observability/test_profile_tool.py Generated-by: OpenAI Codex Change-Id: Id2514011d61c4d79b501f52dc0b1c1fcf7b11b06 Reviewed-on: http://gerrit.cloudera.org:8080/24378 Reviewed-by: Impala Public Jenkins <[email protected]> Tested-by: Impala Public Jenkins <[email protected]> --- M be/src/util/impala-profile-tool.cc M tests/observability/test_profile_tool.py 2 files changed, 59 insertions(+), 7 deletions(-) Approvals: Impala Public Jenkins: Looks good to me, approved; Verified -- To view, visit http://gerrit.cloudera.org:8080/24378 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: Id2514011d61c4d79b501f52dc0b1c1fcf7b11b06 Gerrit-Change-Number: 24378 Gerrit-PatchSet: 5 Gerrit-Owner: Aleksandr Efimov <[email protected]> Gerrit-Reviewer: Aleksandr Efimov <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Peter Rozsa <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]>
