Tianyi Wang has posted comments on this change. ( http://gerrit.cloudera.org:8080/10792 )
Change subject: IMPALA-3040: Remove cache directives if a partition is dropped externally ...................................................................... Patch Set 4: (6 comments) http://gerrit.cloudera.org:8080/#/c/10792/3//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/10792/3//COMMIT_MSG@7 PS3, Line 7: if a partition is dropped externally > may be say external table drops? Done http://gerrit.cloudera.org:8080/#/c/10792/3//COMMIT_MSG@9 PS3, Line 9: > Add some context about what happens when it is dropped from Hive. Done http://gerrit.cloudera.org:8080/#/c/10792/3//COMMIT_MSG@13 PS3, Line 13: table/database, the cache directive won't be removed even if the table > Could you add a test for this in test_hdfs_caching? Done http://gerrit.cloudera.org:8080/#/c/10792/3/fe/src/main/java/org/apache/impala/catalog/HdfsTable.java File fe/src/main/java/org/apache/impala/catalog/HdfsTable.java: http://gerrit.cloudera.org:8080/#/c/10792/3/fe/src/main/java/org/apache/impala/catalog/HdfsTable.java@1158 PS3, Line 1158: * HdfsPartition that was dropped or null if the partition does not exist. > Update that this drops the cache directive if its cached. Done http://gerrit.cloudera.org:8080/#/c/10792/3/fe/src/main/java/org/apache/impala/catalog/HdfsTable.java@1191 PS3, Line 1191: // If there are multiple partition ids corresponding to a literal, remove > I think this should only run on the Catalog server? I checked the callers of this function and it can only be called from catalogd. http://gerrit.cloudera.org:8080/#/c/10792/3/fe/src/main/java/org/apache/impala/catalog/HdfsTable.java@1193 PS3, Line 1193: if (partitionIds.size() > 1) partitionIds.remove(partitionId); > Do we need to remove a similar check from CatalogOpEx#alterTableDropPartiti Done -- To view, visit http://gerrit.cloudera.org:8080/10792 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id7701a499405e961456adea63f3592b43bd69170 Gerrit-Change-Number: 10792 Gerrit-PatchSet: 4 Gerrit-Owner: Tianyi Wang <[email protected]> Gerrit-Reviewer: Bharath Vissapragada <[email protected]> Gerrit-Reviewer: Tianyi Wang <[email protected]> Gerrit-Comment-Date: Wed, 04 Jul 2018 00:54:31 +0000 Gerrit-HasComments: Yes
