Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/10792 )
Change subject: IMPALA-3040: Remove cache directives if a partition is dropped externally ...................................................................... Patch Set 4: Code-Review+2 (3 comments) http://gerrit.cloudera.org:8080/#/c/10792/4/fe/src/main/java/org/apache/impala/catalog/HdfsTable.java File fe/src/main/java/org/apache/impala/catalog/HdfsTable.java: http://gerrit.cloudera.org:8080/#/c/10792/4/fe/src/main/java/org/apache/impala/catalog/HdfsTable.java@1174 PS4, Line 1174: LOG.error("Unable to remove a cache directive: " + e.getMessage()) Please include table and partition name in the message. Also do something like LOG.error(msg, e) so that the stack trace is printed too. http://gerrit.cloudera.org:8080/#/c/10792/4/tests/query_test/test_hdfs_caching.py File tests/query_test/test_hdfs_caching.py: http://gerrit.cloudera.org:8080/#/c/10792/4/tests/query_test/test_hdfs_caching.py@291 PS4, Line 291: assert num_entries_pre + 1 == get_num_cache_requests() nit: add comments like in L287. Something like we expect the partition cache directive to be dropped etc.. http://gerrit.cloudera.org:8080/#/c/10792/4/tests/query_test/test_hdfs_caching.py@292 PS4, Line 292: self.client.execute("drop table cached_tbl_part") nit: Do we need to put the drop in a finally block? since we are using 'cached_tbl_part' in different tests, if the cleanup does not happen for some reason (due to test errors etc) other tests could potentially fail (for ex: L224). Or just use another/random table name to avoid this mess. -- To view, visit http://gerrit.cloudera.org:8080/10792 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id7701a499405e961456adea63f3592b43bd69170 Gerrit-Change-Number: 10792 Gerrit-PatchSet: 4 Gerrit-Owner: Tianyi Wang <[email protected]> Gerrit-Reviewer: Bharath Vissapragada <[email protected]> Gerrit-Reviewer: Tianyi Wang <[email protected]> Gerrit-Comment-Date: Wed, 04 Jul 2018 06:48:06 +0000 Gerrit-HasComments: Yes
