Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/24534 )
Change subject: POC: Add GEOMETRY type for WKB_EXPERIMENTAL mode ...................................................................... Patch Set 5: (3 comments) gerrit-auto-critic failed. You can reproduce it locally using command: python3 bin/jenkins/critique-gerrit-review.py --dryrun To run it, you might need a virtual env with Python3's venv installed. http://gerrit.cloudera.org:8080/#/c/24534/5/be/src/runtime/types.h File be/src/runtime/types.h: http://gerrit.cloudera.org:8080/#/c/24534/5/be/src/runtime/types.h@297 PS5, Line 297: // backend - only some code parts, e.g. file format readers/writers differentiate between line too long (91 > 90) http://gerrit.cloudera.org:8080/#/c/24534/5/fe/src/compat-hive-3/java/org/apache/impala/compat/HiveEsriGeospatialBuiltins.java File fe/src/compat-hive-3/java/org/apache/impala/compat/HiveEsriGeospatialBuiltins.java: http://gerrit.cloudera.org:8080/#/c/24534/5/fe/src/compat-hive-3/java/org/apache/impala/compat/HiveEsriGeospatialBuiltins.java@31 PS5, Line 31: import org.apache.impala.hive.geospatial.esri.*; star import is not allowed. If you do need it, add it to JAVA_STAR_IMPORT_ALLOW_LIST in bin/jenkins/critique-gerrit-review.py. http://gerrit.cloudera.org:8080/#/c/24534/5/fe/src/compat-hive-3/java/org/apache/impala/compat/HiveEsriGeospatialBuiltins.java@88 PS5, Line 88: // Functions that take raw bytes and produce geometry (BINARY -> GEOMETRY in WKB mode). line too long (91 > 90) -- To view, visit http://gerrit.cloudera.org:8080/24534 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0ff29cb15ab45f3899bf453041e605a32f195c27 Gerrit-Change-Number: 24534 Gerrit-PatchSet: 5 Gerrit-Owner: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Balazs Hevele <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Peter Rozsa <[email protected]> Gerrit-Comment-Date: Thu, 09 Jul 2026 14:27:50 +0000 Gerrit-HasComments: Yes
