Balazs Hevele has posted comments on this change. ( http://gerrit.cloudera.org:8080/24534 )
Change subject: POC: Add GEOMETRY type for WKB_EXPERIMENTAL mode ...................................................................... Patch Set 5: Code-Review+1 (2 comments) http://gerrit.cloudera.org:8080/#/c/24534/5/be/src/runtime/types.cc File be/src/runtime/types.cc: http://gerrit.cloudera.org:8080/#/c/24534/5/be/src/runtime/types.cc@210 PS5, Line 210: if (col_type == TPrimitiveType::GEOMETRY) { : return "geometry"; : } else if (col_type == TPrimitiveType::BINARY) { : return "binary"; : } else { : return "string"; : } nit: why not a switch? http://gerrit.cloudera.org:8080/#/c/24534/5/fe/src/test/java/org/apache/impala/analysis/AnalyzeDDLTest.java File fe/src/test/java/org/apache/impala/analysis/AnalyzeDDLTest.java: http://gerrit.cloudera.org:8080/#/c/24534/5/fe/src/test/java/org/apache/impala/analysis/AnalyzeDDLTest.java@4254 PS5, Line 4254: today nit: strange phrasing -- To view, visit http://gerrit.cloudera.org:8080/24534 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0ff29cb15ab45f3899bf453041e605a32f195c27 Gerrit-Change-Number: 24534 Gerrit-PatchSet: 5 Gerrit-Owner: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Balazs Hevele <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Peter Rozsa <[email protected]> Gerrit-Comment-Date: Fri, 10 Jul 2026 09:51:02 +0000 Gerrit-HasComments: Yes
