Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/24534 )
Change subject: POC IMPALA-15161: Add GEOMETRY type for WKB_EXPERIMENTAL mode ...................................................................... Patch Set 7: (2 comments) thanks for the review! there are still some major TODOs in the patch, so I don't consider it ready to be merged, but the high level architecture is probably final http://gerrit.cloudera.org:8080/#/c/24534/5/be/src/runtime/types.cc File be/src/runtime/types.cc: http://gerrit.cloudera.org:8080/#/c/24534/5/be/src/runtime/types.cc@210 PS5, Line 210: case TYPE_TIMESTAMP: return "timestamp"; : case TYPE_STRING: : switch (col_type) { : case TPrimitiveType::GEOMETRY: return "geometry"; : case TPrimitiveType::BINARY: return "binary"; : default: return "string"; : } > nit: why not a switch? Done http://gerrit.cloudera.org:8080/#/c/24534/5/fe/src/test/java/org/apache/impala/analysis/AnalyzeDDLTest.java File fe/src/test/java/org/apache/impala/analysis/AnalyzeDDLTest.java: http://gerrit.cloudera.org:8080/#/c/24534/5/fe/src/test/java/org/apache/impala/analysis/AnalyzeDDLTest.java@4254 PS5, Line 4254: nalys > nit: strange phrasing Done -- To view, visit http://gerrit.cloudera.org:8080/24534 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0ff29cb15ab45f3899bf453041e605a32f195c27 Gerrit-Change-Number: 24534 Gerrit-PatchSet: 7 Gerrit-Owner: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Balazs Hevele <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Peter Rozsa <[email protected]> Gerrit-Comment-Date: Fri, 10 Jul 2026 10:26:17 +0000 Gerrit-HasComments: Yes
