Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/24590 )
Change subject: IMPALA-9821: Change DataSketches functions to return BINARY ...................................................................... Patch Set 1: (1 comment) lgtm at high level, but I would remove the STRING overloads http://gerrit.cloudera.org:8080/#/c/24590/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/24590/1//COMMIT_MSG@50 PS1, Line 50: Backward compatibility: All STRING overloads are preserved. I wouldn't keep these. The ticket was intentionally a breaking change to do before Impala 5 -- To view, visit http://gerrit.cloudera.org:8080/24590 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id4a6b54089dd356e37257bc24adeb1eb98e82c25 Gerrit-Change-Number: 24590 Gerrit-PatchSet: 1 Gerrit-Owner: Mihaly Szjatinya <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Mihaly Szjatinya <[email protected]> Gerrit-Comment-Date: Thu, 16 Jul 2026 09:31:44 +0000 Gerrit-HasComments: Yes
