Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/24590 )
Change subject: IMPALA-9821: Change DataSketches functions to return BINARY ...................................................................... Patch Set 1: > > Patch Set 1: > > > > (1 comment) > > > > lgtm at high level, but I would remove the STRING overloads > > Just to clarify. The ticket says about the DS generating, i.e. > returning functions, and those ARE breaking. But you mean also the > consumer functions should be breaking? Yes. The two generally belong together, e.g. the input of ds_theta_estimate is the result of a function that generates a theta sketch - if those functions return a binary, than the functions that gets it should also expect a binary. By keeping both string and binary overload we can avoid a few cases where the query would need to be rewritten (e.g. someone explicitly casts to STRING), but generally it is the best to rewrite to use BINARY consistently. -- To view, visit http://gerrit.cloudera.org:8080/24590 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id4a6b54089dd356e37257bc24adeb1eb98e82c25 Gerrit-Change-Number: 24590 Gerrit-PatchSet: 1 Gerrit-Owner: Mihaly Szjatinya <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Mihaly Szjatinya <[email protected]> Gerrit-Comment-Date: Thu, 16 Jul 2026 11:55:25 +0000 Gerrit-HasComments: No
