Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/24590 )

Change subject: IMPALA-9821: Change DataSketches functions to return BINARY
......................................................................


Patch Set 2:

(1 comment)

gerrit-auto-critic failed. You can reproduce it locally using command:

  python3 bin/jenkins/critique-gerrit-review.py --dryrun

To run it, you might need a virtual env with Python3's venv installed.

http://gerrit.cloudera.org:8080/#/c/24590/2/tests/query_test/test_datasketches.py
File tests/query_test/test_datasketches.py:

http://gerrit.cloudera.org:8080/#/c/24590/2/tests/query_test/test_datasketches.py@40
PS2, Line 40: q
flake8: F841 local variable 'qualified' is assigned to but never used



--
To view, visit http://gerrit.cloudera.org:8080/24590
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id4a6b54089dd356e37257bc24adeb1eb98e82c25
Gerrit-Change-Number: 24590
Gerrit-PatchSet: 2
Gerrit-Owner: Mihaly Szjatinya <[email protected]>
Gerrit-Reviewer: Csaba Ringhofer <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Mihaly Szjatinya <[email protected]>
Gerrit-Comment-Date: Tue, 21 Jul 2026 08:59:44 +0000
Gerrit-HasComments: Yes

Reply via email to