Zoltan Borok-Nagy has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/24543 )

Change subject: IMPALA-15054: Set EXPAND_COMPLEX_TYPES to true by default
......................................................................


Patch Set 7: Code-Review+2

(2 comments)

Thanks for the review. Carry +2

http://gerrit.cloudera.org:8080/#/c/24543/6/fe/src/test/java/org/apache/impala/analysis/AnalyzerTest.java
File fe/src/test/java/org/apache/impala/analysis/AnalyzerTest.java:

http://gerrit.cloudera.org:8080/#/c/24543/6/fe/src/test/java/org/apache/impala/analysis/AnalyzerTest.java@348
PS6, Line 348:     AnalyzesOk(
             :         "select input__file__name, * from 
functional_parquet.complextypestbl c, " +
             :         "c.int_array arr
> Is this comment really useful?
Removed.


http://gerrit.cloudera.org:8080/#/c/24543/6/testdata/workloads/functional-planner/queries/PlannerTest/empty.test
File testdata/workloads/functional-planner/queries/PlannerTest/empty.test:

http://gerrit.cloudera.org:8080/#/c/24543/6/testdata/workloads/functional-planner/queries/PlannerTest/empty.test@609
PS6, Line 609: select * from tpch_nested_parquet.customer c, c.c_orders o limit 0
             : ---- PLAN
             : PLAN-ROOT SINK
> is this comment really useful?
Removed



--
To view, visit http://gerrit.cloudera.org:8080/24543
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6cf01f0b6bb3b5fa2aa770c77bc772abf9cc84b2
Gerrit-Change-Number: 24543
Gerrit-PatchSet: 7
Gerrit-Owner: Zoltan Borok-Nagy <[email protected]>
Gerrit-Reviewer: Csaba Ringhofer <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Michael Smith <[email protected]>
Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]>
Gerrit-Comment-Date: Wed, 22 Jul 2026 08:43:19 +0000
Gerrit-HasComments: Yes

Reply via email to