Aleksandr Efimov has posted comments on this change. ( http://gerrit.cloudera.org:8080/24597 )
Change subject: IMPALA-7996: Optimize constant-false outer joins ...................................................................... Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/24597/1/fe/src/main/java/org/apache/impala/planner/SingleNodePlanner.java File fe/src/main/java/org/apache/impala/planner/SingleNodePlanner.java: http://gerrit.cloudera.org:8080/#/c/24597/1/fe/src/main/java/org/apache/impala/planner/SingleNodePlanner.java@2120 PS1, Line 2120: eqJoinConjuncts.clear(); > This fix may still cause data skew for FULL OUTER JOIN ON FALSE/NULL: hashi Thanks — addressed in PS2. Constant-false outer joins are now marked and both inputs are RANDOM-partitioned for partitioned execution, so FULL OUTER JOIN no longer funnels constant keys to one executor. LEFT/RIGHT still replace the non-preserved side with EmptySetNode. I considered UNION ALL/null-extension, but it would require rematerializing the join's multi-tuple output and rebuilding its smap/nullability contract; the RANDOM hash-join path preserves that contract. Added distributed planner coverage for LEFT/RIGHT/FULL. -- To view, visit http://gerrit.cloudera.org:8080/24597 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6505825fc958720eec12e13d546661834f221b80 Gerrit-Change-Number: 24597 Gerrit-PatchSet: 2 Gerrit-Owner: Aleksandr Efimov <[email protected]> Gerrit-Reviewer: Aleksandr Efimov <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Paul Rogers <[email protected]> Gerrit-Reviewer: Yifan Zhang <[email protected]> Gerrit-Comment-Date: Wed, 22 Jul 2026 10:18:20 +0000 Gerrit-HasComments: Yes
