Aleksandr Efimov has posted comments on this change. ( http://gerrit.cloudera.org:8080/24597 )
Change subject: IMPALA-7996: Optimize constant-false outer joins ...................................................................... Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/24597/2/fe/src/main/java/org/apache/impala/planner/SingleNodePlanner.java File fe/src/main/java/org/apache/impala/planner/SingleNodePlanner.java: http://gerrit.cloudera.org:8080/#/c/24597/2/fe/src/main/java/org/apache/impala/planner/SingleNodePlanner.java@2118 PS2, Line 2118: IS_NULL_VALUE.a > nit: IS_NULL_LITERAL misses a folded CAST(NULL AS <type>) — should use Good catch — fixed in PS3 by switching to IS_NULL_VALUE, which covers both NullLiteral and typed CAST(NULL AS <type>). Updated the planner/runtime cases to exercise CAST(NULL AS BOOLEAN); the exact-SHA FE package and focused planner test passed. -- To view, visit http://gerrit.cloudera.org:8080/24597 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6505825fc958720eec12e13d546661834f221b80 Gerrit-Change-Number: 24597 Gerrit-PatchSet: 3 Gerrit-Owner: Aleksandr Efimov <[email protected]> Gerrit-Reviewer: Aleksandr Efimov <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Paul Rogers <[email protected]> Gerrit-Reviewer: Steve Carlin <[email protected]> Gerrit-Reviewer: Yifan Zhang <[email protected]> Gerrit-Comment-Date: Thu, 23 Jul 2026 11:14:39 +0000 Gerrit-HasComments: Yes
