Yifan Zhang has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/24597 )

Change subject: IMPALA-7996: Optimize constant-false outer joins
......................................................................


Patch Set 2: Code-Review+1

(1 comment)

http://gerrit.cloudera.org:8080/#/c/24597/2/fe/src/main/java/org/apache/impala/planner/SingleNodePlanner.java
File fe/src/main/java/org/apache/impala/planner/SingleNodePlanner.java:

http://gerrit.cloudera.org:8080/#/c/24597/2/fe/src/main/java/org/apache/impala/planner/SingleNodePlanner.java@2118
PS2, Line 2118: IS_NULL_LITERAL
nit: IS_NULL_LITERAL misses a folded CAST(NULL AS <type>) — should use
IS_NULL_VALUE.



--
To view, visit http://gerrit.cloudera.org:8080/24597
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6505825fc958720eec12e13d546661834f221b80
Gerrit-Change-Number: 24597
Gerrit-PatchSet: 2
Gerrit-Owner: Aleksandr Efimov <[email protected]>
Gerrit-Reviewer: Aleksandr Efimov <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Michael Smith <[email protected]>
Gerrit-Reviewer: Paul Rogers <[email protected]>
Gerrit-Reviewer: Steve Carlin <[email protected]>
Gerrit-Reviewer: Yifan Zhang <[email protected]>
Gerrit-Comment-Date: Thu, 23 Jul 2026 09:41:11 +0000
Gerrit-HasComments: Yes

Reply via email to