Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/10884 )
Change subject: IMPALA-7239: Disable smaps parsing by default ...................................................................... Patch Set 1: (3 comments) Should this be considered incompatible? eg would a downstream metrics program (eg CM) have problems with us removing these metrics by default? http://gerrit.cloudera.org:8080/#/c/10884/1/be/src/util/memory-metrics.cc File be/src/util/memory-metrics.cc: http://gerrit.cloudera.org:8080/#/c/10884/1/be/src/util/memory-metrics.cc@35 PS1, Line 35: enable_all_memory_metrics instead of "all" perhaps "smaps" or "extended" or something? http://gerrit.cloudera.org:8080/#/c/10884/1/be/src/util/memory-metrics.cc@124 PS1, Line 124: AggregateMemoryMetrics::NUM_MAPS = if we still care about NUM_MAPS we could parse /proc/self/maps instead of smaps, which I believe is much faster http://gerrit.cloudera.org:8080/#/c/10884/1/be/src/util/memory-metrics.cc@128 PS1, Line 128: AggregateMemoryMetrics::RSS = aggregate_metrics->AddGauge("memory.rss", 0U); RSS is available in /proc/self/status if we care -- To view, visit http://gerrit.cloudera.org:8080/10884 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I235eddde8fe925866e0581b235752354a3f36d5b Gerrit-Change-Number: 10884 Gerrit-PatchSet: 1 Gerrit-Owner: Tim Armstrong <[email protected]> Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Comment-Date: Fri, 06 Jul 2018 19:26:59 +0000 Gerrit-HasComments: Yes
