Tim Armstrong has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/10884 )

Change subject: IMPALA-7239: Disable smaps parsing by default
......................................................................


Patch Set 2:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/10884/2/be/src/util/process-state-info.cc
File be/src/util/process-state-info.cc:

http://gerrit.cloudera.org:8080/#/c/10884/2/be/src/util/process-state-info.cc@178
PS2, Line 178: string ProcessStateInfo::DebugString() const {
> I dunno where this is used, but would it make sense to not include the bits
It's used on the debug page. Fixed it.



--
To view, visit http://gerrit.cloudera.org:8080/10884
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I235eddde8fe925866e0581b235752354a3f36d5b
Gerrit-Change-Number: 10884
Gerrit-PatchSet: 2
Gerrit-Owner: Tim Armstrong <tarmstr...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com>
Gerrit-Reviewer: Todd Lipcon <t...@apache.org>
Gerrit-Comment-Date: Wed, 11 Jul 2018 18:48:45 +0000
Gerrit-HasComments: Yes

Reply via email to