Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/10884 )
Change subject: IMPALA-7239: Disable smaps parsing by default ...................................................................... Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/10884/1/be/src/util/memory-metrics.cc File be/src/util/memory-metrics.cc: http://gerrit.cloudera.org:8080/#/c/10884/1/be/src/util/memory-metrics.cc@124 PS1, Line 124: if (FLAGS_enable_extended_memory_metrics && MemInfo::HaveSmaps()) { > I did some experiments on a CentOS7 system where we saw some perf issues an that's interesting, thanks for checking. http://gerrit.cloudera.org:8080/#/c/10884/2/be/src/util/process-state-info.cc File be/src/util/process-state-info.cc: http://gerrit.cloudera.org:8080/#/c/10884/2/be/src/util/process-state-info.cc@178 PS2, Line 178: string ProcessStateInfo::DebugString() const { I dunno where this is used, but would it make sense to not include the bits of info that weren't read if get_extended_metrics was passed as false? It seems here they'll all get printed as -1. -- To view, visit http://gerrit.cloudera.org:8080/10884 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I235eddde8fe925866e0581b235752354a3f36d5b Gerrit-Change-Number: 10884 Gerrit-PatchSet: 2 Gerrit-Owner: Tim Armstrong <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Comment-Date: Fri, 06 Jul 2018 20:59:47 +0000 Gerrit-HasComments: Yes
