Gokul Kolady has posted comments on this change. ( http://gerrit.cloudera.org:8080/24502 )
Change subject: IMPALA-15107: Support Direct Thrift Upload for AI Profile Analyzer ...................................................................... Patch Set 5: (5 comments) http://gerrit.cloudera.org:8080/#/c/24502/3/be/src/kudu/util/web_callback_registry.h File be/src/kudu/util/web_callback_registry.h: http://gerrit.cloudera.org:8080/#/c/24502/3/be/src/kudu/util/web_callback_registry.h@33 PS3, Line 33: NotFound, // 404 > Nit, move this line down 1 to keep the status codes sorted numerically. Done http://gerrit.cloudera.org:8080/#/c/24502/3/be/src/service/impala-http-handler.cc File be/src/service/impala-http-handler.cc: http://gerrit.cloudera.org:8080/#/c/24502/3/be/src/service/impala-http-handler.cc@536 PS3, Line 536: st_args = Webserver::GetVars(req.post_data); > This seems not a deep copy, should we declare "Webserver::ArgumentMap post_ Done http://gerrit.cloudera.org:8080/#/c/24502/3/be/src/service/impala-http-handler.cc@559 PS3, Line 559: return; : } : Value analysis_value(analysis, document.GetAllocator()); : d > Can this be moved up so that calls to WriteJsonDocumentToStream() will have Done http://gerrit.cloudera.org:8080/#/c/24502/3/be/src/util/runtime-profile.cc File be/src/util/runtime-profile.cc: http://gerrit.cloudera.org:8080/#/c/24502/3/be/src/util/runtime-profile.cc@39 PS3, Line 39: #include "runtime/summary-stats.h" > Most of the changes in this file appear to have been made in error or possi Removed unnecessary changes http://gerrit.cloudera.org:8080/#/c/24502/3/be/src/util/webserver.cc File be/src/util/webserver.cc: http://gerrit.cloudera.org:8080/#/c/24502/3/be/src/util/webserver.cc@230 PS3, Line 230: case HttpStatusCode::NotFound: > Nit, move down so the return codes are in numeric order. Done -- To view, visit http://gerrit.cloudera.org:8080/24502 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iff05c3cde7b34a56e31f020611cc33ff4e02aa32 Gerrit-Change-Number: 24502 Gerrit-PatchSet: 5 Gerrit-Owner: Gokul Kolady <[email protected]> Gerrit-Reviewer: Abhishek Rawat <[email protected]> Gerrit-Reviewer: Gokul Kolady <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jason Fehr <[email protected]> Gerrit-Reviewer: Yida Wu <[email protected]> Gerrit-Comment-Date: Wed, 29 Jul 2026 19:56:16 +0000 Gerrit-HasComments: Yes
