Jason Fehr has posted comments on this change. ( http://gerrit.cloudera.org:8080/24502 )
Change subject: IMPALA-15107: Support Direct Thrift Upload for AI Profile Analyzer ...................................................................... Patch Set 3: (4 comments) http://gerrit.cloudera.org:8080/#/c/24502/3/be/src/kudu/util/web_callback_registry.h File be/src/kudu/util/web_callback_registry.h: http://gerrit.cloudera.org:8080/#/c/24502/3/be/src/kudu/util/web_callback_registry.h@33 PS3, Line 33: MethodNotAllowed, // 405 Nit, move this line down 1 to keep the status codes sorted numerically. http://gerrit.cloudera.org:8080/#/c/24502/3/be/src/service/impala-http-handler.cc File be/src/service/impala-http-handler.cc: http://gerrit.cloudera.org:8080/#/c/24502/3/be/src/service/impala-http-handler.cc@559 PS3, Line 559: if (has_query_id) { : Value query_id(PrintId(unique_id), document.GetAllocator()); : document.AddMember("query_id", query_id, document.GetAllocator()); : } Can this be moved up so that calls to WriteJsonDocumentToStream() will have the query id included for error situations? http://gerrit.cloudera.org:8080/#/c/24502/3/be/src/util/runtime-profile.cc File be/src/util/runtime-profile.cc: http://gerrit.cloudera.org:8080/#/c/24502/3/be/src/util/runtime-profile.cc@39 PS3, Line 39: #include "rpc/thrift-util.h" Most of the changes in this file appear to have been made in error or possibly the change needs to be rebased off the master branch? http://gerrit.cloudera.org:8080/#/c/24502/3/be/src/util/webserver.cc File be/src/util/webserver.cc: http://gerrit.cloudera.org:8080/#/c/24502/3/be/src/util/webserver.cc@230 PS3, Line 230: case HttpStatusCode::MethodNotAllowed: Nit, move down so the return codes are in numeric order. -- To view, visit http://gerrit.cloudera.org:8080/24502 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iff05c3cde7b34a56e31f020611cc33ff4e02aa32 Gerrit-Change-Number: 24502 Gerrit-PatchSet: 3 Gerrit-Owner: Gokul Kolady <[email protected]> Gerrit-Reviewer: Abhishek Rawat <[email protected]> Gerrit-Reviewer: Gokul Kolady <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jason Fehr <[email protected]> Gerrit-Reviewer: Yida Wu <[email protected]> Gerrit-Comment-Date: Mon, 27 Jul 2026 23:57:17 +0000 Gerrit-HasComments: Yes
