Yida Wu has posted comments on this change. ( http://gerrit.cloudera.org:8080/24502 )
Change subject: IMPALA-15107: Support Direct Thrift Upload for AI Profile Analyzer ...................................................................... Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/24502/3/be/src/service/impala-http-handler.cc File be/src/service/impala-http-handler.cc: http://gerrit.cloudera.org:8080/#/c/24502/3/be/src/service/impala-http-handler.cc@536 PS3, Line 536: thrift_profile_archive = thrift_profile_arg->second; This seems not a deep copy, should we declare "Webserver::ArgumentMap post_args;" outside the if block so the strings live long enough? -- To view, visit http://gerrit.cloudera.org:8080/24502 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iff05c3cde7b34a56e31f020611cc33ff4e02aa32 Gerrit-Change-Number: 24502 Gerrit-PatchSet: 3 Gerrit-Owner: Gokul Kolady <[email protected]> Gerrit-Reviewer: Abhishek Rawat <[email protected]> Gerrit-Reviewer: Gokul Kolady <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jason Fehr <[email protected]> Gerrit-Reviewer: Yida Wu <[email protected]> Gerrit-Comment-Date: Fri, 24 Jul 2026 22:18:59 +0000 Gerrit-HasComments: Yes
