Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/24572 )
Change subject: IMPALA-15171: Null out Iceberg delete file path slot after the join ...................................................................... Patch Set 7: (1 comment) http://gerrit.cloudera.org:8080/#/c/24572/5/fe/src/main/java/org/apache/impala/planner/IcebergScanPlanner.java File fe/src/main/java/org/apache/impala/planner/IcebergScanPlanner.java: http://gerrit.cloudera.org:8080/#/c/24572/5/fe/src/main/java/org/apache/impala/planner/IcebergScanPlanner.java@443 PS5, Line 443: // this call materializes it solely for the delete join, so the backend can null it : // out on the join output. : Path resolvedPath; > This is invoked during the planning phase, the Analyzer should have already "Assume that if the slot was not registered during analyses then this is the only place where it is used during planning" It would be nice enforce this, e.g. mark the SlotDesc as singleUse/nodeBound (don't have a good name) and hit a preconditon check if registerSlotRef or addSlotRefToDesc returns such a SlotDesc, but this would not work if it is used with getSlotDescriptor(). -- To view, visit http://gerrit.cloudera.org:8080/24572 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7e662cb6a98dd3e687185d384731d6be45f91b94 Gerrit-Change-Number: 24572 Gerrit-PatchSet: 7 Gerrit-Owner: Zoltan Borok-Nagy <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Noemi Pap-Takacs <[email protected]> Gerrit-Reviewer: Peter Rozsa <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Fri, 31 Jul 2026 06:57:47 +0000 Gerrit-HasComments: Yes
