Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/24572 )
Change subject: IMPALA-15171: Null out Iceberg delete file path slot after the join ...................................................................... Patch Set 8: (5 comments) http://gerrit.cloudera.org:8080/#/c/24572/5//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/24572/5//COMMIT_MSG@9 PS5, Line 9: IcebergScanPlanner materializes the INPUT__FILE__NAME (file path) > ack, yeah, for pure v3 tables doing it in the scanner seems the cleanest an Created a ticket for the file id thing: IMPALA-15241 http://gerrit.cloudera.org:8080/#/c/24572/8/fe/src/main/java/org/apache/impala/planner/IcebergDeleteJoinNode.java File fe/src/main/java/org/apache/impala/planner/IcebergDeleteJoinNode.java: http://gerrit.cloudera.org:8080/#/c/24572/8/fe/src/main/java/org/apache/impala/planner/IcebergDeleteJoinNode.java@177 PS8, Line 177: if (clearFilePathSlot_) { : output.append(detailPrefix + "clear file path slot\n"); : } I wouldn't add this at standard explain level - move in last block to only add it in verbose level? http://gerrit.cloudera.org:8080/#/c/24572/8/fe/src/main/java/org/apache/impala/planner/IcebergScanNode.java File fe/src/main/java/org/apache/impala/planner/IcebergScanNode.java: http://gerrit.cloudera.org:8080/#/c/24572/8/fe/src/main/java/org/apache/impala/planner/IcebergScanNode.java@311 PS8, Line 311: This doesn't look consistent with IcebergDeleteJoinNode, it only add it above TExplainLevel. IMO the best would be to only add it at verbose level. http://gerrit.cloudera.org:8080/#/c/24572/8/testdata/workloads/functional-planner/queries/PlannerTest/iceberg-v2-tables.test File testdata/workloads/functional-planner/queries/PlannerTest/iceberg-v2-tables.test: http://gerrit.cloudera.org:8080/#/c/24572/8/testdata/workloads/functional-planner/queries/PlannerTest/iceberg-v2-tables.test@56 PS8, Line 56: clear file path slot While handy for tests, I am not sure that this really worth the noise in production. http://gerrit.cloudera.org:8080/#/c/24572/8/tests/query_test/test_iceberg.py File tests/query_test/test_iceberg.py: http://gerrit.cloudera.org:8080/#/c/24572/8/tests/query_test/test_iceberg.py@2972 PS8, Line 2972: tpch_parquet.lineitem Isn't there a suitable table in dataload? Fyi I am thinking about dropping some formats in tpch/tpcds and adding iceberg instead. There could be even multiple kind of tables, for example tphch_iceberg_v2_deletes, where some rows would be deleted (and re-added to keep contents the same). IMPALA-14366 is about cleaning up file format dimension. -- To view, visit http://gerrit.cloudera.org:8080/24572 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7e662cb6a98dd3e687185d384731d6be45f91b94 Gerrit-Change-Number: 24572 Gerrit-PatchSet: 8 Gerrit-Owner: Zoltan Borok-Nagy <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Noemi Pap-Takacs <[email protected]> Gerrit-Reviewer: Peter Rozsa <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Tue, 04 Aug 2026 06:20:09 +0000 Gerrit-HasComments: Yes
