Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/24572 )
Change subject: IMPALA-15171: Null out Iceberg delete file path slot after the join ...................................................................... Patch Set 8: (3 comments) http://gerrit.cloudera.org:8080/#/c/24572/8/fe/src/main/java/org/apache/impala/planner/IcebergDeleteJoinNode.java File fe/src/main/java/org/apache/impala/planner/IcebergDeleteJoinNode.java: http://gerrit.cloudera.org:8080/#/c/24572/8/fe/src/main/java/org/apache/impala/planner/IcebergDeleteJoinNode.java@177 PS8, Line 177: if (clearFilePathSlot_) { : output.append(detailPrefix + "clear file path slot\n"); : } > I wouldn't add this at standard explain level - move in last block to only I think EXTENDED level would be better so we would see them in query profiles. http://gerrit.cloudera.org:8080/#/c/24572/8/fe/src/main/java/org/apache/impala/planner/IcebergScanNode.java File fe/src/main/java/org/apache/impala/planner/IcebergScanNode.java: http://gerrit.cloudera.org:8080/#/c/24572/8/fe/src/main/java/org/apache/impala/planner/IcebergScanNode.java@311 PS8, Line 311: > This doesn't look consistent with IcebergDeleteJoinNode, it only add it abo getDerivedExplainString() is only invoked on >= STANDARD level, so it's currently consistent with IcebergDeleteJoinNode. But it's true that it's not obvious from the code. E.g. HdfsScanNode should always invoke getDerivedExplainString() and here we should gate messages based on explain level. http://gerrit.cloudera.org:8080/#/c/24572/8/tests/query_test/test_iceberg.py File tests/query_test/test_iceberg.py: http://gerrit.cloudera.org:8080/#/c/24572/8/tests/query_test/test_iceberg.py@2972 PS8, Line 2972: tpch_parquet.lineitem > Isn't there a suitable table in dataload? The pre-loaded Iceberg tables are too small I think. I can make ice_lineitem smaller with extra predicates. We can switch in the future when there are Iceberg tpch/tpcds pre-loaded tables with deletes. -- To view, visit http://gerrit.cloudera.org:8080/24572 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7e662cb6a98dd3e687185d384731d6be45f91b94 Gerrit-Change-Number: 24572 Gerrit-PatchSet: 8 Gerrit-Owner: Zoltan Borok-Nagy <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Noemi Pap-Takacs <[email protected]> Gerrit-Reviewer: Peter Rozsa <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Tue, 04 Aug 2026 08:59:01 +0000 Gerrit-HasComments: Yes
