Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/24166 )
Change subject: IMPALA-14684: Add metrics for catalogd table invalidations ...................................................................... Patch Set 12: (1 comment) http://gerrit.cloudera.org:8080/#/c/24166/12/fe/src/main/java/org/apache/impala/catalog/CatalogdTableInvalidator.java File fe/src/main/java/org/apache/impala/catalog/CatalogdTableInvalidator.java: http://gerrit.cloudera.org:8080/#/c/24166/12/fe/src/main/java/org/apache/impala/catalog/CatalogdTableInvalidator.java@313 PS12, Line 313: appendBatch(ttlInvalidationBatches_, timeSourceMillis(), count); Can we use the same timestamp, System.currentTimeMillis(), in lastTtlInvalidationBatch_ and appending the batch? I think they should be consistent. appendBatch() can return the new batch that just being added. We then set lastTtlInvalidationBatch_ the result. lastTtlInvalidationBatch_ = appendBatch(ttlInvalidationBatches_, count); In appendBatch(), we read System.currentTimeMillis() once and use the timestamp in the batch and in calculating the cutoff time. -- To view, visit http://gerrit.cloudera.org:8080/24166 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If78e6c8429801e3c1829860666f04ad287b826ab Gerrit-Change-Number: 24166 Gerrit-PatchSet: 12 Gerrit-Owner: Arnab Karmakar <[email protected]> Gerrit-Reviewer: Arnab Karmakar <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Nandor Kollar <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Comment-Date: Tue, 04 Aug 2026 12:17:48 +0000 Gerrit-HasComments: Yes
