Arnab Karmakar has posted comments on this change. ( http://gerrit.cloudera.org:8080/24166 )
Change subject: IMPALA-14684: Add metrics for catalogd table invalidations ...................................................................... Patch Set 12: (2 comments) http://gerrit.cloudera.org:8080/#/c/24166/11/fe/src/main/java/org/apache/impala/catalog/CatalogdTableInvalidator.java File fe/src/main/java/org/apache/impala/catalog/CatalogdTableInvalidator.java: http://gerrit.cloudera.org:8080/#/c/24166/11/fe/src/main/java/org/apache/impala/catalog/CatalogdTableInvalidator.java@107 PS11, Line 107: timestamp in > nit: it's not elapsed-time. Just remove this word. Done http://gerrit.cloudera.org:8080/#/c/24166/11/fe/src/main/java/org/apache/impala/catalog/CatalogdTableInvalidator.java@311 PS11, Line 311: lastTtlInvalidationBatch_ = : new InvalidationBatch(System.currentTimeMillis(), count) > It's confusing to use two kinds of timestamps (ms and ns) here. Do we reall Done -- To view, visit http://gerrit.cloudera.org:8080/24166 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If78e6c8429801e3c1829860666f04ad287b826ab Gerrit-Change-Number: 24166 Gerrit-PatchSet: 12 Gerrit-Owner: Arnab Karmakar <[email protected]> Gerrit-Reviewer: Arnab Karmakar <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Nandor Kollar <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Comment-Date: Tue, 04 Aug 2026 06:42:50 +0000 Gerrit-HasComments: Yes
