Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/24166 )
Change subject: IMPALA-14684: Add metrics for catalogd table invalidations ...................................................................... Patch Set 11: (2 comments) http://gerrit.cloudera.org:8080/#/c/24166/11/fe/src/main/java/org/apache/impala/catalog/CatalogdTableInvalidator.java File fe/src/main/java/org/apache/impala/catalog/CatalogdTableInvalidator.java: http://gerrit.cloudera.org:8080/#/c/24166/11/fe/src/main/java/org/apache/impala/catalog/CatalogdTableInvalidator.java@107 PS11, Line 107: elapsed-time nit: it's not elapsed-time. Just remove this word. http://gerrit.cloudera.org:8080/#/c/24166/11/fe/src/main/java/org/apache/impala/catalog/CatalogdTableInvalidator.java@311 PS11, Line 311: new InvalidationBatch(System.currentTimeMillis(), count); : appendBatch(ttlInvalidationBatches_, timestampNanos, count); It's confusing to use two kinds of timestamps (ms and ns) here. Do we really need nanosecond precision here? I think multiple invalidations won't happen inside one millisecond. -- To view, visit http://gerrit.cloudera.org:8080/24166 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If78e6c8429801e3c1829860666f04ad287b826ab Gerrit-Change-Number: 24166 Gerrit-PatchSet: 11 Gerrit-Owner: Arnab Karmakar <[email protected]> Gerrit-Reviewer: Arnab Karmakar <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Nandor Kollar <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Comment-Date: Tue, 04 Aug 2026 04:50:01 +0000 Gerrit-HasComments: Yes
