Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/24665 )
Change subject: IMPALA-15243: Fix costing for CTEs ...................................................................... Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/24665/2/fe/src/main/java/org/apache/impala/planner/CostingSegment.java File fe/src/main/java/org/apache/impala/planner/CostingSegment.java: http://gerrit.cloudera.org:8080/#/c/24665/2/fe/src/main/java/org/apache/impala/planner/CostingSegment.java@182 PS2, Line 182: segmentCore = CoreCount.sum(segmentCore, childCores.first); > Could we avoid counting a shared producer more than once here? DistributedP I'm not sure it makes sense to avoid all duplicates here. We should avoid duplicate counting within the same segment, but across segments raises the question of sharing the count. I think the point of this is identifying pipeline parallelism, so each consumer should probably match up with the producer's parallelism. http://gerrit.cloudera.org:8080/#/c/24665/2/fe/src/main/java/org/apache/impala/planner/PlanFragment.java File fe/src/main/java/org/apache/impala/planner/PlanFragment.java: http://gerrit.cloudera.org:8080/#/c/24665/2/fe/src/main/java/org/apache/impala/planner/PlanFragment.java@1346 PS2, Line 1346: verdict = ScalingVerdict.SCAN_FRAGMENT_BOUNDED; > Would it make sense to preserve the consumer's original instance count here Yeah, I think a more strict restriction would make sense for the moment. -- To view, visit http://gerrit.cloudera.org:8080/24665 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I21b60af313070029a1fa8bf835107bef88f54912 Gerrit-Change-Number: 24665 Gerrit-PatchSet: 2 Gerrit-Owner: Michael Smith <[email protected]> Gerrit-Reviewer: Aleksandr Efimov <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Kurt Deschler <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Stamatis Zampetakis <[email protected]> Gerrit-Comment-Date: Thu, 06 Aug 2026 17:53:50 +0000 Gerrit-HasComments: Yes
