Aleksandr Efimov has posted comments on this change. ( http://gerrit.cloudera.org:8080/24665 )
Change subject: IMPALA-15243: Fix costing for CTEs ...................................................................... Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/24665/2/fe/src/main/java/org/apache/impala/planner/CostingSegment.java File fe/src/main/java/org/apache/impala/planner/CostingSegment.java: http://gerrit.cloudera.org:8080/#/c/24665/2/fe/src/main/java/org/apache/impala/planner/CostingSegment.java@182 PS2, Line 182: segmentCore = CoreCount.sum(segmentCore, childCores.first); > Ok, that makes sense - if the point is pipeline parallelism then matching e Re-checked on PS9 now that q39a/q39b are in the suite: still no fragment in DISTRIBUTEDPLAN or PARALLELPLANS with two consumers of the same CTE. q39a's F00 and F10 each hold three consumers, but of three different CTEs, so each maps to a different producer fragment and the guard never fires. Would a planner test with a union over the same CTE twice be worth adding, so this doesn't quietly rot? -- To view, visit http://gerrit.cloudera.org:8080/24665 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I21b60af313070029a1fa8bf835107bef88f54912 Gerrit-Change-Number: 24665 Gerrit-PatchSet: 2 Gerrit-Owner: Michael Smith <[email protected]> Gerrit-Reviewer: Aleksandr Efimov <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Kurt Deschler <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Stamatis Zampetakis <[email protected]> Gerrit-Comment-Date: Tue, 18 Aug 2026 10:38:32 +0000 Gerrit-HasComments: Yes
