Aleksandr Efimov has posted comments on this change. ( http://gerrit.cloudera.org:8080/24665 )
Change subject: IMPALA-15243: Fix costing for CTEs ...................................................................... Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/24665/3/fe/src/main/java/org/apache/impala/planner/PlanFragment.java File fe/src/main/java/org/apache/impala/planner/PlanFragment.java: http://gerrit.cloudera.org:8080/#/c/24665/3/fe/src/main/java/org/apache/impala/planner/PlanFragment.java@1278 PS3, Line 1278: } else if (isCTEConsumerFragment()) { Minor, on the new branch: this is the only non-fixed path that doesn't clamp selectedParallelism to maxThreadAllowed, and the checkState at the end of the method asserts exactly that. If a plan gives a consumer fragment more instances per host than maxThreadPerNode, planning would throw. isFixedParallelism_ has the same shape, so maybe there's a guarantee I'm not seeing - is there? Also this now runs before isPartitionedJoinBuildFragment(), so a fragment that's both would stop following the parent's parallelism. I couldn't construct such a plan (consumers always start their own RANDOM fragment), so probably not reachable today - a Preconditions.checkState here would make that assumption explicit. -- To view, visit http://gerrit.cloudera.org:8080/24665 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I21b60af313070029a1fa8bf835107bef88f54912 Gerrit-Change-Number: 24665 Gerrit-PatchSet: 3 Gerrit-Owner: Michael Smith <[email protected]> Gerrit-Reviewer: Aleksandr Efimov <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Kurt Deschler <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Stamatis Zampetakis <[email protected]> Gerrit-Comment-Date: Thu, 06 Aug 2026 19:13:40 +0000 Gerrit-HasComments: Yes
