Nandor Kollar has posted comments on this change. ( http://gerrit.cloudera.org:8080/24655 )
Change subject: IMPALA-15233: Remove catch blocks in MetastoreServiceHandler after HIVE-27193 ...................................................................... Patch Set 2: Code-Review+1 (2 comments) http://gerrit.cloudera.org:8080/#/c/24655/2/fe/src/main/java/org/apache/impala/catalog/metastore/MetastoreServiceHandler.java File fe/src/main/java/org/apache/impala/catalog/metastore/MetastoreServiceHandler.java: http://gerrit.cloudera.org:8080/#/c/24655/2/fe/src/main/java/org/apache/impala/catalog/metastore/MetastoreServiceHandler.java@3138 PS2, Line 3138: dbName = MetaStoreUtils.parseDbName(dbNameWithCatalog, serverConf_)[1]; Can we simplify this: ` String dbName = dbNameWithCatalog; // Parse db name. dbName = MetaStoreUtils.parseDbName(dbNameWithCatalog, serverConf_)[1];` to this: ` // Parse db name. String dbName = MetaStoreUtils.parseDbName(dbNameWithCatalog, serverConf_)[1];` http://gerrit.cloudera.org:8080/#/c/24655/2/fe/src/main/java/org/apache/impala/catalog/metastore/MetastoreServiceHandler.java@3241 PS2, Line 3241: toParse = oldDbNameWithCatalog; Can we please also remote this `toParse` variable? I don't see any reason to keep it. -- To view, visit http://gerrit.cloudera.org:8080/24655 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia7ff36a1631910d039808f46f45fc1dd59e9f400 Gerrit-Change-Number: 24655 Gerrit-PatchSet: 2 Gerrit-Owner: Fang-Yu Rao <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Nandor Kollar <[email protected]> Gerrit-Comment-Date: Fri, 14 Aug 2026 07:16:35 +0000 Gerrit-HasComments: Yes
