Fang-Yu Rao has posted comments on this change. ( http://gerrit.cloudera.org:8080/24655 )
Change subject: IMPALA-15233: Remove catch blocks in MetastoreServiceHandler after HIVE-27193 ...................................................................... Patch Set 3: (2 comments) Thanks Nandor! I have addressed the comments on patch set 2. http://gerrit.cloudera.org:8080/#/c/24655/2/fe/src/main/java/org/apache/impala/catalog/metastore/MetastoreServiceHandler.java File fe/src/main/java/org/apache/impala/catalog/metastore/MetastoreServiceHandler.java: http://gerrit.cloudera.org:8080/#/c/24655/2/fe/src/main/java/org/apache/impala/catalog/metastore/MetastoreServiceHandler.java@3138 PS2, Line 3138: try { > Can we simplify this: Done http://gerrit.cloudera.org:8080/#/c/24655/2/fe/src/main/java/org/apache/impala/catalog/metastore/MetastoreServiceHandler.java@3241 PS2, Line 3241: TTableName oldTable = new TTableName(oldDbName, oldTableName); > Can we please also remote this `toParse` variable? I don't see any reason t Done -- To view, visit http://gerrit.cloudera.org:8080/24655 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia7ff36a1631910d039808f46f45fc1dd59e9f400 Gerrit-Change-Number: 24655 Gerrit-PatchSet: 3 Gerrit-Owner: Fang-Yu Rao <[email protected]> Gerrit-Reviewer: Fang-Yu Rao <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Nandor Kollar <[email protected]> Gerrit-Comment-Date: Mon, 17 Aug 2026 16:50:29 +0000 Gerrit-HasComments: Yes
