Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/24665 )
Change subject: IMPALA-15243: Fix costing for CTEs ...................................................................... Patch Set 11: (4 comments) http://gerrit.cloudera.org:8080/#/c/24665/2/fe/src/main/java/org/apache/impala/planner/CostingSegment.java File fe/src/main/java/org/apache/impala/planner/CostingSegment.java: http://gerrit.cloudera.org:8080/#/c/24665/2/fe/src/main/java/org/apache/impala/planner/CostingSegment.java@182 PS2, Line 182: // its CoreCount will be added to the subtreeCoreBuilder. > Re-checked on PS9 now that q39a/q39b are in the suite: still no fragment in Done http://gerrit.cloudera.org:8080/#/c/24665/9/fe/src/main/java/org/apache/impala/planner/CostingSegment.java File fe/src/main/java/org/apache/impala/planner/CostingSegment.java: http://gerrit.cloudera.org:8080/#/c/24665/9/fe/src/main/java/org/apache/impala/planner/CostingSegment.java@177 PS9, Line 177: if (childCores == null) { > The comment says the producer "will be visited later and its CoreCount will Done http://gerrit.cloudera.org:8080/#/c/24665/9/fe/src/main/java/org/apache/impala/planner/PlanFragment.java File fe/src/main/java/org/apache/impala/planner/PlanFragment.java: http://gerrit.cloudera.org:8080/#/c/24665/9/fe/src/main/java/org/apache/impala/planner/PlanFragment.java@1144 PS9, Line 1144: && verdict != ScalingVerdict.FIXED_BY_PARTITIONED_JOIN_BUILD > Coming back to this from PS3, since the code is unchanged: the cap still sk Seems reasonable. http://gerrit.cloudera.org:8080/#/c/24665/9/fe/src/main/java/org/apache/impala/planner/PlanFragment.java@1278 PS9, Line 1278: } > Also from PS3, same reason: this is the only non-fixed path that doesn't cl Done -- To view, visit http://gerrit.cloudera.org:8080/24665 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I21b60af313070029a1fa8bf835107bef88f54912 Gerrit-Change-Number: 24665 Gerrit-PatchSet: 11 Gerrit-Owner: Michael Smith <[email protected]> Gerrit-Reviewer: Aleksandr Efimov <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Kurt Deschler <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Stamatis Zampetakis <[email protected]> Gerrit-Comment-Date: Tue, 18 Aug 2026 18:07:41 +0000 Gerrit-HasComments: Yes
