Aleksandr Efimov has posted comments on this change. ( http://gerrit.cloudera.org:8080/24665 )
Change subject: IMPALA-15243: Fix costing for CTEs ...................................................................... Patch Set 12: Code-Review+1 (1 comment) PS12 looks good to me. All four points from the last round are addressed, and the new cte-distributed.test case is exactly the shape I was asking about: F02 holds two consumers of cte_suggestion_0 (04 and 05) feeding off the same producer fragment F04, so the dedup guard is now covered by a test. Also, in case it saves you a look: the red check on PS10 looks unrelated too. clang-tidy-ub2004 #14568 failed in the build step with a pip metadata-generation-failed on the impala_python3 target, and #14569 on PS11 passed with no relevant change in between. http://gerrit.cloudera.org:8080/#/c/24665/12/fe/src/main/java/org/apache/impala/planner/CostingSegment.java File fe/src/main/java/org/apache/impala/planner/CostingSegment.java: http://gerrit.cloudera.org:8080/#/c/24665/12/fe/src/main/java/org/apache/impala/planner/CostingSegment.java@182 PS12, Line 182: // its CoreCount will be added to the subtreeCoreBuilder. Checked the new test: the union-over-one-CTE query puts 04 and 05, both consumers of cte_suggestion_0, into fragment F02, which is what the guard needs. Thanks for adding it. -- To view, visit http://gerrit.cloudera.org:8080/24665 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I21b60af313070029a1fa8bf835107bef88f54912 Gerrit-Change-Number: 24665 Gerrit-PatchSet: 12 Gerrit-Owner: Michael Smith <[email protected]> Gerrit-Reviewer: Aleksandr Efimov <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Kurt Deschler <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Stamatis Zampetakis <[email protected]> Gerrit-Comment-Date: Tue, 18 Aug 2026 20:07:48 +0000 Gerrit-HasComments: Yes
