Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/24709 )
Change subject: IMPALA-15269: Decimal operands in comparisons do not need casting ...................................................................... Patch Set 3: (2 comments) gerrit-auto-critic failed. You can reproduce it locally using command: python3 bin/jenkins/critique-gerrit-review.py --dryrun To run it, you might need a virtual env with Python3's venv installed. http://gerrit.cloudera.org:8080/#/c/24709/3/java/calcite-planner/src/main/java/org/apache/impala/calcite/operators/ImpalaConvertletTable.java File java/calcite-planner/src/main/java/org/apache/impala/calcite/operators/ImpalaConvertletTable.java: http://gerrit.cloudera.org:8080/#/c/24709/3/java/calcite-planner/src/main/java/org/apache/impala/calcite/operators/ImpalaConvertletTable.java@27 PS3, Line 27: import org.apache.calcite.sql.SqlKind; unused import: org.apache.calcite.sql.SqlKind http://gerrit.cloudera.org:8080/#/c/24709/3/java/calcite-planner/src/main/java/org/apache/impala/calcite/operators/ImpalaConvertletTable.java@65 PS3, Line 65: registerOp(ImpalaCustomOperatorTable.IS_NOT_DISTINCT_FROM, this::convertIsNotDistinctFrom); line too long (95 > 90) -- To view, visit http://gerrit.cloudera.org:8080/24709 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I226e4a7d105e963f3263fb8a71acb5fdef7ffa94 Gerrit-Change-Number: 24709 Gerrit-PatchSet: 3 Gerrit-Owner: Steve Carlin <[email protected]> Gerrit-Reviewer: Aman Sinha <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jason Fehr <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Comment-Date: Thu, 20 Aug 2026 13:40:09 +0000 Gerrit-HasComments: Yes
