Hello Aman Sinha, Jason Fehr, Aleksandr Efimov, Joe McDonnell, Michael Smith,
Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/24709
to look at the new patch set (#5).
Change subject: IMPALA-15269: Decimal operands in comparisons do not need
casting
......................................................................
IMPALA-15269: Decimal operands in comparisons do not need casting
In the Calcite planner, we need to avoid the casting of decimal operands
in binary comparisons. Before this commit, a query failed because it
could not find a compatible decimal to dec(22,8) and dec(36,35).
Testing: Ran e2e suite with Calcite planner on to make sure there
were no wrong results.
Change-Id: I226e4a7d105e963f3263fb8a71acb5fdef7ffa94
---
M java/calcite-planner/src/main/codegen/templates/Parser.jj
M
java/calcite-planner/src/main/java/org/apache/impala/calcite/operators/ImpalaConvertletTable.java
M
java/calcite-planner/src/main/java/org/apache/impala/calcite/operators/ImpalaCustomOperatorTable.java
M testdata/workloads/functional-query/queries/QueryTest/calcite.test
4 files changed, 101 insertions(+), 10 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/09/24709/5
--
To view, visit http://gerrit.cloudera.org:8080/24709
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I226e4a7d105e963f3263fb8a71acb5fdef7ffa94
Gerrit-Change-Number: 24709
Gerrit-PatchSet: 5
Gerrit-Owner: Steve Carlin <[email protected]>
Gerrit-Reviewer: Aleksandr Efimov <[email protected]>
Gerrit-Reviewer: Aman Sinha <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Jason Fehr <[email protected]>
Gerrit-Reviewer: Joe McDonnell <[email protected]>
Gerrit-Reviewer: Michael Smith <[email protected]>
Gerrit-Reviewer: Steve Carlin <[email protected]>
