Aleksandr Efimov has posted comments on this change. ( http://gerrit.cloudera.org:8080/24709 )
Change subject: IMPALA-15269: Decimal operands in comparisons do not need casting ...................................................................... Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/24709/4/java/calcite-planner/src/main/java/org/apache/impala/calcite/operators/ImpalaCustomOperatorTable.java File java/calcite-planner/src/main/java/org/apache/impala/calcite/operators/ImpalaCustomOperatorTable.java: http://gerrit.cloudera.org:8080/#/c/24709/4/java/calcite-planner/src/main/java/org/apache/impala/calcite/operators/ImpalaCustomOperatorTable.java@235 PS4, Line 235: public static final SqlBinaryOperator EQUALS = > Ok, I went and changed the Parser.jj. It makes it more clear now. One thing that may help with the convertlet question: JoinRelationInfo.java:158 and ImpalaLoptOptimizeJoinRule.java:220 both compare by identity, getOperator() != SqlStdOperatorTable.EQUALS on a RexCall. In PS4 that was safe either way, since the Rex call inherited the standard operator from the parser. Now the convertlet is what keeps them working - without it an equi-join condition arrives with the custom operator, both checks fall through, and the join quietly loses its equi-join key. So it reads as load-bearing rather than leftover. Should <NULL_SAFE_EQUAL> and IS [NOT] DISTINCT FROM move over as well? They still hand out the std instances, and mixing the two tables is easy to misread later. -- To view, visit http://gerrit.cloudera.org:8080/24709 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I226e4a7d105e963f3263fb8a71acb5fdef7ffa94 Gerrit-Change-Number: 24709 Gerrit-PatchSet: 4 Gerrit-Owner: Steve Carlin <[email protected]> Gerrit-Reviewer: Aleksandr Efimov <[email protected]> Gerrit-Reviewer: Aman Sinha <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jason Fehr <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Steve Carlin <[email protected]> Gerrit-Comment-Date: Sun, 23 Aug 2026 17:09:06 +0000 Gerrit-HasComments: Yes
