Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/24661 )
Change subject: IMPALA-15247: Unify not-comparable type checks in Type.throwIfNotComparable ...................................................................... Patch Set 4: (2 comments) http://gerrit.cloudera.org:8080/#/c/24661/3/fe/src/main/java/org/apache/impala/analysis/MultiAggregateInfo.java File fe/src/main/java/org/apache/impala/analysis/MultiAggregateInfo.java: http://gerrit.cloudera.org:8080/#/c/24661/3/fe/src/main/java/org/apache/impala/analysis/MultiAggregateInfo.java@262 PS3, Line 262: are not supported as DISTIN > no need to mention now as the function call to throwIfNotComparable shows i Done http://gerrit.cloudera.org:8080/#/c/24661/3/fe/src/main/java/org/apache/impala/catalog/Type.java File fe/src/main/java/org/apache/impala/catalog/Type.java: http://gerrit.cloudera.org:8080/#/c/24661/3/fe/src/main/java/org/apache/impala/catalog/Type.java@292 PS3, Line 292: > The call sites asking for an overload that takes the SQL representation of Added expr as parameter. It could be even more compact if Expr would get a function like throwIfResultIsNotComparable(String prefix). -- To view, visit http://gerrit.cloudera.org:8080/24661 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2dc2c4579508cf1f8954ac251087c52f2eddf36a Gerrit-Change-Number: 24661 Gerrit-PatchSet: 4 Gerrit-Owner: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Balazs Hevele <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Peter Rozsa <[email protected]> Gerrit-Comment-Date: Sat, 22 Aug 2026 17:55:25 +0000 Gerrit-HasComments: Yes
