Fang-Yu Rao has posted comments on this change. ( http://gerrit.cloudera.org:8080/24717 )
Change subject: IMPALA-15277: Address test failures related MetastoreEventsProcessorTest ...................................................................... Patch Set 7: (2 comments) I have addressed Quanlong's comments on patch set 5. Let me know if there are additional suggestions. Thanks! http://gerrit.cloudera.org:8080/#/c/24717/5/fe/src/test/java/org/apache/impala/catalog/events/MetastoreEventsProcessorTest.java File fe/src/test/java/org/apache/impala/catalog/events/MetastoreEventsProcessorTest.java: http://gerrit.cloudera.org:8080/#/c/24717/5/fe/src/test/java/org/apache/impala/catalog/events/MetastoreEventsProcessorTest.java@3764 PS5, Line 3764: reateEventId, /*filter*/null, > nit: please update the comments on L3751-3759. Maybe also mention the Hive Done http://gerrit.cloudera.org:8080/#/c/24717/5/fe/src/test/java/org/apache/impala/catalog/events/MetastoreEventsProcessorTest.java@3959 PS5, Line 3959: sb.append(" ").append(filteredEvent).append('\n'); > nit: can we print the events if this fails? Yes. In patch set 7, we will print the events if this fails. -- To view, visit http://gerrit.cloudera.org:8080/24717 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I30d810609fccaac73a0eb4e3f2e257521a3da10f Gerrit-Change-Number: 24717 Gerrit-PatchSet: 7 Gerrit-Owner: Fang-Yu Rao <[email protected]> Gerrit-Reviewer: Anonymous Coward <[email protected]> Gerrit-Reviewer: Fang-Yu Rao <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Sai Hemanth Gantasala <[email protected]> Gerrit-Comment-Date: Sun, 23 Aug 2026 19:03:06 +0000 Gerrit-HasComments: Yes
