Aleksandr Efimov has posted comments on this change. ( http://gerrit.cloudera.org:8080/24217 )
Change subject: IMPALA-14911: Calcite planner: Fix boolean to numeric comparison ...................................................................... Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/24217/2/java/calcite-planner/src/main/java/org/apache/impala/calcite/type/ImpalaTypeCoercionImpl.java File java/calcite-planner/src/main/java/org/apache/impala/calcite/type/ImpalaTypeCoercionImpl.java: http://gerrit.cloudera.org:8080/#/c/24217/2/java/calcite-planner/src/main/java/org/apache/impala/calcite/type/ImpalaTypeCoercionImpl.java@123 PS2, Line 123: if (SqlTypeUtil.isBoolean(type1) && SqlTypeUtil.isNumeric(type2)) { > I do realize that the Calcite planner isn't enabled for this suite. But I' That plan makes sense to me. I ran the new file under the Calcite planner to see where it stands today: with fallback_planner=none, 29 of the 37 statements pass, explain checks included. The eight that fail are the negative ones - STRING/DATE/TIMESTAMP/BINARY against BOOLEAN come back as "Invalid type cast from STRING to BOOLEAN" instead of "operands of type STRING and BOOLEAN are not comparable". With fallback_planner=original the whole file is green, since those eight fall back. So the background build will keep it green either way; noting it for whenever the no-fallback run arrives. -- To view, visit http://gerrit.cloudera.org:8080/24217 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I764dcbd2fd0d1323bfb964ed91d94cd3def594c0 Gerrit-Change-Number: 24217 Gerrit-PatchSet: 2 Gerrit-Owner: Steve Carlin <[email protected]> Gerrit-Reviewer: Aleksandr Efimov <[email protected]> Gerrit-Reviewer: Aman Sinha <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jason Fehr <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Steve Carlin <[email protected]> Gerrit-Comment-Date: Tue, 25 Aug 2026 16:13:38 +0000 Gerrit-HasComments: Yes
