Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/24217 )
Change subject: IMPALA-14911: Calcite planner: Fix boolean to numeric comparison ...................................................................... Patch Set 7: (1 comment) http://gerrit.cloudera.org:8080/#/c/24217/7/testdata/workloads/functional-query/queries/QueryTest/binary_exprs_with_boolean.test File testdata/workloads/functional-query/queries/QueryTest/binary_exprs_with_boolean.test: http://gerrit.cloudera.org:8080/#/c/24217/7/testdata/workloads/functional-query/queries/QueryTest/binary_exprs_with_boolean.test@324 PS7, Line 324: select binary_col = bool_col as a from test_bool_binary_eq order by a; > This is the "=" case again (line 178) - I think the ">" variant was meant h I'd be willing to +2 once this comment is addressed. -- To view, visit http://gerrit.cloudera.org:8080/24217 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I764dcbd2fd0d1323bfb964ed91d94cd3def594c0 Gerrit-Change-Number: 24217 Gerrit-PatchSet: 7 Gerrit-Owner: Steve Carlin <[email protected]> Gerrit-Reviewer: Aleksandr Efimov <[email protected]> Gerrit-Reviewer: Aman Sinha <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jason Fehr <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Steve Carlin <[email protected]> Gerrit-Comment-Date: Tue, 22 Sep 2026 18:40:52 +0000 Gerrit-HasComments: Yes
