Aleksandr Efimov has posted comments on this change. ( http://gerrit.cloudera.org:8080/24707 )
Change subject: IMPALA-15270: Implement Geospatial ST_Buffer Function Using Boost ...................................................................... Patch Set 6: (1 comment) http://gerrit.cloudera.org:8080/#/c/24707/6/be/src/exprs/geo/geometry-wrapper-wkb.cc File be/src/exprs/geo/geometry-wrapper-wkb.cc: http://gerrit.cloudera.org:8080/#/c/24707/6/be/src/exprs/geo/geometry-wrapper-wkb.cc@643 PS6, Line 643: points_per_circle_ *= 4; > The size_t change covers both the truncation and the multiplication, thanks The cap is in, thanks. About the default: the check runs before the *= 4, so quad_segs=999999 is still accepted and gives just under 4M points per circle - the last row of the probe above, where one buffer call took 0.46 s and peaked around 295 MB of process RSS. So the default leaves that cost where it was; what it adds is a knob an operator can turn down. Was it meant to bound the cost, or just to keep the multiplication in range? If the former, something in the low thousands would match the numbers - quad_segs=1000 came out at 4001 points and 0.00 s. -- To view, visit http://gerrit.cloudera.org:8080/24707 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6faeb533eb464d32629fa402179dc19c25bd78f2 Gerrit-Change-Number: 24707 Gerrit-PatchSet: 6 Gerrit-Owner: Jason Fehr <[email protected]> Gerrit-Reviewer: Aleksandr Efimov <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jason Fehr <[email protected]> Gerrit-Comment-Date: Wed, 26 Aug 2026 17:32:21 +0000 Gerrit-HasComments: Yes
